-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feedback): add spam detection to project settings #66740
Conversation
@@ -0,0 +1,22 @@ | |||
import type {JsonFormObject} from 'sentry/components/forms/types'; | |||
|
|||
export const route = '/settings/:orgId/projects/:projectId/user-feedback-processing/'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find an import for this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copied from a previous file, but in those i see this:
// Export route to make these forms searchable by label/help
so maybe it's necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That menu is starting to get unwieldly, but I don't have a good solution
too many settings! |
Create a User Feedback section under the Processing header, to add a spam detection toggle in project settings. We already have a User Feedback section under SDK Setup, but I didn't think that spam fit in with SDK setup. The result is that we now have two User Feedback sections in the settings (open to ideas for consolidating or renaming):
![SCR-20240311-nuse](https://private-user-images.githubusercontent.com/56095982/311886300-d702ebe0-6b29-4f4f-bd16-b631bace6d26.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2OTc5MTIsIm5iZiI6MTczOTY5NzYxMiwicGF0aCI6Ii81NjA5NTk4Mi8zMTE4ODYzMDAtZDcwMmViZTAtNmIyOS00ZjRmLWJkMTYtYjYzMWJhY2U2ZDI2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDA5MjAxMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA1YTQ3YjBmMGQxYzFmMjdiM2U1YTExNzRkMTZlODVhZTBmZThkYmEyZjkzZjBlZmZhNmZkOTQyYzA4NzZkMDYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.OkyHVGIhFwK-douffSW7sVhUGoP8OZpipp771faG0bY)
The new page looks like this:
![SCR-20240311-numj](https://private-user-images.githubusercontent.com/56095982/311886308-6cc13770-129e-40bb-b074-8a63b51eec8e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2OTc5MTIsIm5iZiI6MTczOTY5NzYxMiwicGF0aCI6Ii81NjA5NTk4Mi8zMTE4ODYzMDgtNmNjMTM3NzAtMTI5ZS00MGJiLWIwNzQtOGE2M2I1MWVlYzhlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDA5MjAxMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ2ZDY2YWM1NTY5MTgxZjYyNjE3OTFlYzQ3NDA4MTZjOGJmMGRiOGRhZTBiNWVmZWZkYTM0NjI0NDViZWQxMWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.vp3ZEf0_IIvHoTeb3Bk-h8fUAs7MKA5ZG4tyQ6TpSY0)
Closes #66731