Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feedback): add spam detection to project settings #66740

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Mar 11, 2024

Create a User Feedback section under the Processing header, to add a spam detection toggle in project settings. We already have a User Feedback section under SDK Setup, but I didn't think that spam fit in with SDK setup. The result is that we now have two User Feedback sections in the settings (open to ideas for consolidating or renaming):
SCR-20240311-nuse

The new page looks like this:
SCR-20240311-numj

Closes #66731

@michellewzhang michellewzhang requested review from JoshFerge and a team March 11, 2024 22:44
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 11, 2024
@@ -0,0 +1,22 @@
import type {JsonFormObject} from 'sentry/components/forms/types';

export const route = '/settings/:orgId/projects/:projectId/user-feedback-processing/';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find an import for this one

Copy link
Member Author

@michellewzhang michellewzhang Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied from a previous file, but in those i see this:
// Export route to make these forms searchable by label/help

so maybe it's necessary

Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That menu is starting to get unwieldly, but I don't have a good solution

@michellewzhang
Copy link
Member Author

That menu is starting to get unwieldly, but I don't have a good solution

too many settings!

@michellewzhang michellewzhang merged commit 46e6377 into master Mar 21, 2024
39 checks passed
@michellewzhang michellewzhang deleted the mz/proj-option-settings-fb branch March 21, 2024 18:10
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add proj options to settings
3 participants