Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anr): Display offending thread stacktrace in case of deadlock #50925

Merged
merged 5 commits into from
Jun 21, 2023
Merged

feat(anr): Display offending thread stacktrace in case of deadlock #50925

merged 5 commits into from
Jun 21, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jun 14, 2023 •
edited
Loading

Prerequisite PR #50814

This is the final piece of the ANR improvements.

  • The frames are now analyzed for presence of the lock field, and if there's one we'll mark the frame as suspect frame.
  • If the lock is containing a thread id that is holding the lock, we'll also display the thread's stacktrace in the Suspect Root Cause section, additionally marking the frame that is holding the lock in that thread.

image

@romtsn romtsn requested review from k-fish and shruthilayaj June 14, 2023 10:56
@romtsn romtsn requested a review from a team as a code owner June 14, 2023 10:56
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 14, 2023
@romtsn romtsn mentioned this pull request Jun 14, 2023
Closed
13 tasks
Base automatically changed from rz/feat/extract-lock-per-frame to master June 14, 2023 11:33
@romtsn romtsn requested a review from a team June 14, 2023 11:33
@romtsn romtsn removed the request for review from a team June 14, 2023 11:34
@romtsn
Copy link
Member Author

romtsn commented Jun 16, 2023

@k-fish could you please take a look or recommend someone? 🙏 this is the last PR from me in this area, I'm gonna be silent for a while after that 😅

wmak
wmak approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@wmak wmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@romtsn romtsn merged commit ee24be8 into master Jun 21, 2023
@romtsn romtsn deleted the rz/feat/display-thread-holding-lock branch June 21, 2023 19:06
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wmak wmak wmak approved these changes

@k-fish k-fish Awaiting requested review from k-fish

@shruthilayaj shruthilayaj Awaiting requested review from shruthilayaj

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romtsn @wmak