feat(anr): Improve ANR root cause analysis #49673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
commented
May 24, 2023
static/app/components/events/interfaces/frame/deprecatedLine.tsx
Outdated
Show resolved
Hide resolved
13 tasks
k-fish
approved these changes
Jun 1, 2023
|
|
||
| for (let index = 0; index < exceptionFrames.length; index++) { | ||
| // iterating the frames in reverse order, because the topmost frames most like the root cause | ||
| for (let index = exceptionFrames.length - 1; index > 0; index--) { |
There was a problem hiding this comment.
What's the max number of frames here? If it's really low we don't really need an early exit by reverse walking this array. Up to you though.
There was a problem hiding this comment.
we need the early exit here in case there are multiple offending frames. The UI is only capable of rendering a single root cause and we're picking the one that is the closest to the exception root cause, that's why we reverse it. Unless I misunderstood your comment :)
There was a problem hiding this comment.
Ah there are multiple, nevermind 👍
|
@k-fish I've merged this, lemme know if I misunderstood and should follow up with some changes. Thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR includes 3 main changes:
Tagcomponent. When the Tag is clicked it automatically scrolls to the Suspect Root Cause section.