Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fileio): Introduce file io performance problem #41646

Merged
merged 7 commits into from
Nov 28, 2022
Merged

feat(fileio): Introduce file io performance problem #41646

merged 7 commits into from
Nov 28, 2022

Conversation

wmak
Copy link
Member

@wmak wmak commented Nov 22, 2022 •
edited
Loading

  • Introduce the file io on main thread performance problem. Not hooking up the options or anything yet. Just want to get the main core of the code ready to go first
  • I think this won't actually create any of the file io perf problems yet since the option is only added to default.py with 0
  • Depends on Auto-Instrumentation UI thread rfcs#36

@wmak
feat(fileio): Introduce file io performance problem
86f8605 
- Introduce the file io on main thread performance problem. Not hooking
  up the options or anything yet. Just want to get the main core of the
  code ready to go first
- I think this won't actually create any of the file io perf problems
  yet since the option is only added to default.py with 0
@wmak wmak requested a review from a team as a code owner November 22, 2022 15:45
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 22, 2022
@wmak wmak requested a review from a team November 22, 2022 15:45
@wmak
ref: Address PR comments
b588538 
- Remove cause_span_ids
- Check for op prefix is file
- Include module in the call stack hashing
@wmak wmak requested a review from mjq-sentry November 23, 2022 18:52
@wmak wmak requested a review from a team November 24, 2022 14:58
gggritso
gggritso reviewed Nov 24, 2022
View reviewed changes
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very awesome! Nits only 👏🏻

tests/sentry/utils/performance_issues/test_performance_detection.py Show resolved Hide resolved
src/sentry/utils/performance_issues/performance_detection.py Outdated Show resolved Hide resolved
fixtures/events/performance_problems/file-io-on-main-thread.json Outdated Show resolved Hide resolved
tests/sentry/utils/performance_issues/test_performance_detection.py Show resolved Hide resolved
@wmak wmak requested a review from gggritso November 24, 2022 16:55
gggritso
gggritso approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B e a utiful

@wmak wmak merged commit b0cdefb into master Nov 28, 2022
@wmak wmak deleted the wmak/feat/introduce-file-io-performance-problem branch November 28, 2022 16:35
@silent1mezzo silent1mezzo mentioned this pull request Dec 2, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@romtsn romtsn romtsn left review comments

@gggritso gggritso gggritso approved these changes

@mjq-sentry mjq-sentry Awaiting requested review from mjq-sentry

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wmak @gggritso @romtsn @mjq-sentry