Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(native-stack-trace-v2): Add more adjusts #30013

Merged
merged 2 commits into from
Nov 15, 2021
Merged

ref(native-stack-trace-v2): Add more adjusts #30013

merged 2 commits into from
Nov 15, 2021

Conversation

priscilawebdev
Copy link
Member

@priscilawebdev priscilawebdev commented Nov 15, 2021 •
edited
Loading

  • Replace js .find with .some because it makes more sense
  • Remove the usage of the utility function defined, because that is not really necessary !!null equals false, !!'' equals false and !!undefined equals false and !!'something' equals true
  • Add extra grid column + gap to the RawContentWrapper only on larger devices, otherwise, a small empty space is shown in the UI

Before:
image

After:

image

@priscilawebdev priscilawebdev requested a review from a team as a code owner November 15, 2021 10:16
@priscilawebdev priscilawebdev requested review from Jesse-Box and a team November 15, 2021 10:18
@github-actions
Copy link
Contributor

size-limit report

Path Base Size (774161c) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.8 KB 52.8 KB +0.01% 🔺
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.89 KB 70.89 KB 0%

Jesse-Box
Jesse-Box approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@Jesse-Box Jesse-Box left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @priscilawebdev

@priscilawebdev priscilawebdev merged commit eefd82b into master Nov 15, 2021
@priscilawebdev priscilawebdev deleted the ref/native-stack-trace-v2-more-adjusts branch November 15, 2021 13:38
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Jesse-Box Jesse-Box Jesse-Box approved these changes

@matejminar matejminar matejminar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@priscilawebdev @Jesse-Box @matejminar