Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(native-stack-trace-v2): Apply design feedback #29989

Merged
merged 4 commits into from
Nov 15, 2021
Merged

ref(native-stack-trace-v2): Apply design feedback #29989

merged 4 commits into from
Nov 15, 2021

Conversation

priscilawebdev
Copy link
Member

@priscilawebdev priscilawebdev commented Nov 12, 2021 •
edited
Loading

  • Fix 'Full Stack'

Before:

oi1

After:
oi2

  • Update space between elements in the header from 16px to 8px

Before:

image

After:

image

  • Update styles, so then the Download button fits well on smaller and larger devices

Before:
1129x848
image

image

After:
1129x848
image

image

  • Download button was slightly bigger in comparison to the Dropdown buttons

Before:

imageAfter:
image

After:

image

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2021 •
edited
Loading

size-limit report

Path Base Size (86d6a1f) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.8 KB 52.8 KB +0.01% 🔺
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.89 KB 70.89 KB 0%

@priscilawebdev priscilawebdev marked this pull request as ready for review November 15, 2021 08:39
@priscilawebdev priscilawebdev requested a review from a team as a code owner November 15, 2021 08:39
@priscilawebdev priscilawebdev requested a review from a team November 15, 2021 09:13
@Jesse-Box
Copy link
Contributor

Nice detailed description @priscilawebdev thanks!

@priscilawebdev priscilawebdev enabled auto-merge (squash) November 15, 2021 09:20
@priscilawebdev priscilawebdev merged commit 774161c into master Nov 15, 2021
@priscilawebdev priscilawebdev deleted the ref/native-stack-trace-v2-design-feedback branch November 15, 2021 09:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matejminar matejminar matejminar approved these changes

@Jesse-Box Jesse-Box Awaiting requested review from Jesse-Box

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@priscilawebdev @Jesse-Box @matejminar