Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(select): Choices -> options keySettings #29975

Merged
merged 1 commit into from
Nov 12, 2021
Merged

ref(select): Choices -> options keySettings #29975

merged 1 commit into from
Nov 12, 2021

Conversation

davidenwang
Copy link
Contributor

Changes from legacy react-select choices to options here:

image

@github-actions
Copy link
Contributor

size-limit report

Path Base Size (8e4005d) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.8 KB 52.8 KB +0.01% 🔺
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.89 KB 70.89 KB 0%

@davidenwang davidenwang requested review from a team November 12, 2021 00:35
@davidenwang davidenwang merged commit ea4ee94 into master Nov 12, 2021
@davidenwang davidenwang deleted the davidenwang/choices-to-options-keySettings branch November 12, 2021 00:41
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evanpurkhiser evanpurkhiser evanpurkhiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidenwang @evanpurkhiser