Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(ui): Deprecate withTeams #29929

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Conversation

davidenwang
Copy link
Contributor

All usages of withTeams to provide a list of teams that components would assume is all teams have been removed. This HOC should be deprecated in favor of useTeams or Teams which allow components to have more granularity of the list of teams they want to request and provide searching/pagination functionality.

  • Marked withTeams as deprecated
  • Added TODOs for remaining usages

@davidenwang davidenwang requested a review from a team November 10, 2021 23:04
@davidenwang davidenwang enabled auto-merge (squash) November 10, 2021 23:22
@davidenwang davidenwang merged commit 38c37e4 into master Nov 10, 2021
@davidenwang davidenwang deleted the davidenwang/deprecate-withTeams branch November 10, 2021 23:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants