feat(tests) Add request matchers to MockApiClient #29910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A while back we added `predicate` to mocked responses. However, we generally only match against query string parameters and or request data. These changes add a `match` option to mock definitions and two higher level methods for matching query data and request payloads. This interface is based on how request matching is done in `responses`. I've updated a subset of our tests to show how the new methods work in comparison to `predicate`. If folks are happy with these changes I can update the other tests and remove predicate as well.
dashed
reviewed
Nov 10, 2021
static/app/__mocks__/api.tsx
Outdated
|
|
||
| return matchesURL && matchesMethod && matchesPredicate; | ||
| let matchersMatch = true; | ||
| response.match.forEach(matcher => { |
There was a problem hiding this comment.
Suggested change
| response.match.forEach(matcher => { | |
| const matchersMatch = response.match.every(matcher => matcher(url, options)); |
dashed
approved these changes
Nov 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while back we added
predicateto mocked responses. However, we generally only match against query string parameters and or request data. These changes add amatchoption to mock definitions and two higher level methods for matching query data and request payloads. This interface is based on how request matching is done inresponses.I've updated a subset of our tests to show how the new methods work in comparison to
predicate. If folks are happy with these changes I can update the other tests and remove predicate as well.