refs(incidents): Remove unused incident stat snapshots and endpoint #29897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We stopped using the incident stats endpoint a while ago when we refactored the alerts page. Since this endpoint is no longer used, it also means that we no longer need to keep historical snapshots of incident statistics. Removing this whole system since it's complicated and a pain to work with.
|
This PR has a migration; here is the generated SQL BEGIN;
--
-- Alter field event_stats_snapshot on incidentsnapshot
--
SET CONSTRAINTS "sentry_incidentsnaps_event_stats_snapshot_9bdbecc5_fk_sentry_ti" IMMEDIATE; ALTER TABLE "sentry_incidentsnapshot" DROP CONSTRAINT "sentry_incidentsnaps_event_stats_snapshot_9bdbecc5_fk_sentry_ti";
--
-- Alter field incident on incidentsnapshot
--
SET CONSTRAINTS "sentry_incidentsnaps_incident_id_855af8a4_fk_sentry_in" IMMEDIATE; ALTER TABLE "sentry_incidentsnapshot" DROP CONSTRAINT "sentry_incidentsnaps_incident_id_855af8a4_fk_sentry_in";
--
-- Alter field incident on pendingincidentsnapshot
--
SET CONSTRAINTS "sentry_pendingincide_incident_id_c02c4af7_fk_sentry_in" IMMEDIATE; ALTER TABLE "sentry_pendingincidentsnapshot" DROP CONSTRAINT "sentry_pendingincide_incident_id_c02c4af7_fk_sentry_in";
COMMIT; |
markstory
approved these changes
Nov 10, 2021
| @instrumented_task( | ||
| name="sentry.incidents.tasks.process_pending_incident_snapshots", queue="incident_snapshots" | ||
| ) | ||
| def process_pending_incident_snapshots(next_id=None): |
There was a problem hiding this comment.
Could we have messages in the queues for this task during a deploy? Should this method stay but as a no-op, or do we ignore any sentry errors that may come from this task vanishing?
There was a problem hiding this comment.
Hmm, I think I'm ok with a couple of errors firing for this task, shouldn't cause any actual problems.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We stopped using the incident stats endpoint a while ago when we refactored the alerts page. Since
this endpoint is no longer used, it also means that we no longer need to keep historical snapshots
of incident statistics. Removing this whole system since it's complicated and a pain to work with.