Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(widget-library): Add Library Widgets to Dashboard #29881

Merged
merged 8 commits into from
Nov 12, 2021

Conversation

shruthilayaj
Copy link
Member

@shruthilayaj shruthilayaj commented Nov 9, 2021

Adds the ability to select multiple pre-built
widgets that can be added to the dashboard by
clicking the 'Confirm' button.

Adds a warning banner if no widgets are selected.

Adds the ability to select multiple pre-built
widgets that can be added to the dashboard by
clicking the 'Confirm' button.
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had one observation about onAddWidget!

Copy link
Member

@wmak wmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments here can be moved to future PRs since this is still feature flagged away

  • Looks like the add is bypassing our widget limit (ie. can create a dashboard with >30 widgets)
  • Darkmode sadness:

image

- Could we make the preview of each widget clickable too instead of only the `select` button

@shruthilayaj
Copy link
Member Author

Comments here can be moved to future PRs since this is still feature flagged away

  • Looks like the add is bypassing our widget limit (ie. can create a dashboard with >30 widgets)
  • Darkmode sadness:
image
  • Could we make the preview of each widget clickable too instead of only the select button

adding tickets for these

@shruthilayaj shruthilayaj deleted the feat/add-library-widgets-to-dashboard branch November 12, 2021 16:54
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants