Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(ts): Convert setup.js -> ts. Improve test typing #29869

Merged
merged 1 commit into from
Nov 10, 2021
Merged

tests(ts): Convert setup.js -> ts. Improve test typing #29869

merged 1 commit into from
Nov 10, 2021

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@evanpurkhiser evanpurkhiser requested a review from a team November 9, 2021 02:27
@evanpurkhiser evanpurkhiser requested review from a team as code owners November 9, 2021 02:27
@evanpurkhiser evanpurkhiser requested a review from a team November 9, 2021 02:27
@evanpurkhiser evanpurkhiser requested a review from a team as a code owner November 9, 2021 02:27
@evanpurkhiser evanpurkhiser requested review from a team and removed request for a team November 9, 2021 02:27
evanpurkhiser
evanpurkhiser commented Nov 9, 2021
View reviewed changes
tests/js/spec/views/settings/projectSecurityAndPrivacy.spec.tsx
const project = TestStubs.ProjectDetails();
// @ts-expect-error
const routerContext = TestStubs.routerContext([
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2021 •
edited
Loading

size-limit report

Path Base Size (345e1ec) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.77 KB 52.77 KB -0.01% 🔽
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.89 KB 70.89 KB 0%

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/tests-ts-convert-setup-js-ts-improve-test-typing branch from 1ffb9df to a9550c5 Compare November 9, 2021 02:30
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/tests-ts-convert-setup-js-ts-improve-test-typing branch from a9550c5 to ed6a104 Compare November 9, 2021 19:47
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/tests-ts-convert-setup-js-ts-improve-test-typing branch from ed6a104 to f020967 Compare November 9, 2021 20:19
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/tests-ts-convert-setup-js-ts-improve-test-typing branch from eae11ad to 03f9947 Compare November 9, 2021 20:22
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/tests-ts-convert-setup-js-ts-improve-test-typing branch from 8d66046 to a6fc2fa Compare November 9, 2021 22:46
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/tests-ts-convert-setup-js-ts-improve-test-typing branch from f7397bf to 6169341 Compare November 9, 2021 23:49
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/tests-ts-convert-setup-js-ts-improve-test-typing branch from 6169341 to 5c6d350 Compare November 10, 2021 21:18
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/tests-ts-convert-setup-js-ts-improve-test-typing branch from 5c6d350 to 2e5c9a2 Compare November 10, 2021 22:17
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/tests-ts-convert-setup-js-ts-improve-test-typing branch from 2e5c9a2 to 66ac013 Compare November 10, 2021 22:47
@evanpurkhiser evanpurkhiser merged commit e8dbe1c into master Nov 10, 2021
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/tests-ts-convert-setup-js-ts-improve-test-typing branch November 10, 2021 23:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markstory markstory markstory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanpurkhiser @markstory