Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Change multiple team selector to not have an icon #29868

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

davidenwang
Copy link
Contributor

Before:
image

After:
image

@davidenwang davidenwang requested a review from a team as a code owner November 9, 2021 02:18
@@ -100,7 +100,7 @@ type TeamActor = {

type TeamOption = {
value: string | null;
label: React.ReactElement;
label: React.ReactElement | string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it just be React.ReactNode?

@davidenwang davidenwang merged commit 048fb68 into master Nov 9, 2021
@davidenwang davidenwang deleted the davidenwang/fix-multiselect-icon branch November 9, 2021 19:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants