Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(ui): Use TeamSelector component for organization invite requests #29864

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

davidenwang
Copy link
Contributor

Change to the team selector here so we don't need to use withTeams here which technically doesn't provide all teams.

image

@davidenwang davidenwang requested a review from a team as a code owner November 9, 2021 02:08
@davidenwang davidenwang requested a review from a team November 9, 2021 02:08
@@ -240,7 +240,7 @@ function TeamSelector(props: Props) {
isOptionDisabled={option => !!option.disabled}
styles={{
...(includeUnassigned ? unassignedSelectStyles : {}),
...placeholderSelectStyles,
...(multiple ? {} : placeholderSelectStyles),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just so we don't show an unnecessary placeholder style for when the multiple prop is true

Copy link
Member

@evanpurkhiser evanpurkhiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn that's nice

@davidenwang davidenwang merged commit b65989e into master Nov 9, 2021
@davidenwang davidenwang deleted the davidenwang/use-teams-member-list branch November 9, 2021 20:38
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants