ref(appstore-connect): Make iTunes credentials optional and stop (re)writing them to DB #29863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
905ecae to
81a6e34
Compare
81a6e34 to
b773cd1
Compare
flub
approved these changes
Nov 9, 2021
src/sentry/lang/native/appconnect.py
Outdated
| for field in dataclasses.fields(self): | ||
| if not getattr(self, field.name, None): | ||
| # Takes advantage of the fact that all non-optional fields are str. | ||
| if not getattr(self, field.name, None) and field.type == str: |
There was a problem hiding this comment.
I don't really understand why this condition needed changing? You removed the fields, all fields are still required.
I don't think this does anything wrong either, this will still work. I only don't know why the extra field.type == str check is needed.
Swatinem
approved these changes
Nov 9, 2021
b773cd1 to
c958597
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #29829, this marks the fields storing iTunes credentials as optional prior to their full removal, and also adds in code to stop writing these to the DB.
Current behaviour is to write in placeholder values into fields meant to store iTunes credentials. Now, new App Store Connect configs will no longer contain these fields, and existing configs that are edited after this is merged and deployed will also have these fields erased.