ref(integrations): Allow pagination on team and user mappings pages #29862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaeta
approved these changes
Nov 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See API 2204
This PR will allow the team mappings and user mappings pages to paginate when they exceed 100 entries. The pagination will be disabled if there are less than 100 entries.
It should be noted that there aren't necessarily only 100 entries in the UI when paginating. We paginate based on the sentry mapping, not the external one. For example: If
#sentryin sentry maps to@sentry-feand@sentry-bein github, both will appear on the page that renders the mappings to#sentry. This behavior can be seen in the mocked demo below (where the page limit was changed to 2 entries).DEMO
Untitled.mov
TODO: