test(ts): Add types to js-stubs #29855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Nov 8, 2021
| AccountEmails: OverridableStubList; | ||
| ActivityFeed: OverridableStub; | ||
| ApiApplication: OverridableStub; | ||
| ApiKey: OverridableStub; |
There was a problem hiding this comment.
Should these generics be filled out as the implementations are all JS only files.
There was a problem hiding this comment.
I would love for them to be. But it's going to be a lot more effort to make types align in our tests :( we probably should do them one at a time
32cb74c to
3a22174
Compare
davidenwang
approved these changes
Nov 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are pretty much just stub types for now. We can expand on these and make them more correct later, or even move them to be part of the stubs themselves (probably best)