feat(ui): Release Details Sidebar component update #29842
Conversation
Update design of release details sidebar and add new component to keep the sidebar headers/content/etc consistent. FIXES WOR-1313
| /** | ||
| * Used to add a new sidebar section on Release Details page. | ||
| */ | ||
| function ReleaseSidebarSection({title, children, icon, ...props}: Props) { |
There was a problem hiding this comment.
The design of sidebar sections and titles is used all over the app (transaction summary, project details, alert rule, ..) not just release details. Should we make something reusable so that we can use it in those places too?
I think this refactor should be done with the whole app in mind, not just release details.
cc @vuluongj20
There was a problem hiding this comment.
For sure, I can update the naming here - I mostly made it to where it should work on any sidebar in the app, but I only updated the Release Details page. Should I start working on updating other pages with this after?
There was a problem hiding this comment.
Renaming sounds like a good idea 👍
| @@ -85,27 +86,28 @@ class CommitAuthorBreakdown extends AsyncComponent<Props, State> { | |||
|
|
|||
| return ( | |||
| <Wrapper> | |||
There was a problem hiding this comment.
Should the SidebarSection have some predefined margin so that they are easily stackable on top of each other?
We could get rid of all these Wrapper components and ensure that the spacing is consistent everywhere.
…ease detail sidebar sections
|
Sweet, I believe you can now kill |
Update design of release details sidebar and add new component to keep the sidebar headers/content/etc consistent. Update the existing release details sidebar sections with the new component.
https://www.figma.com/file/kvA3xwx5D7dLuOljIJffvc/Audits?node-id=2%3A68
https://www.figma.com/file/jsZJ9v8ditpm4uBISafH9P/Releases-V4?node-id=1241%3A16163
cc @robinrendle
FIXES WOR-1313
Before
After