Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(lint): Avoid changing Optional[int] -> int | None #29836

Merged
merged 1 commit into from
Nov 8, 2021
Merged

ci(lint): Avoid changing Optional[int] -> int | None #29836

merged 1 commit into from
Nov 8, 2021

Conversation

evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented Nov 5, 2021 •
edited
Loading

This is making too many changes right now that we're not sure if we're happy with.

This also turns off Union[a, b] -> a | b unfortunately. but we're ok w/ that for now

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner November 5, 2021 23:15
@evanpurkhiser evanpurkhiser requested review from a team and removed request for a team November 5, 2021 23:15
wedamija
wedamija approved these changes Nov 5, 2021 •
edited
Loading
View reviewed changes
@evanpurkhiser evanpurkhiser merged commit ee7e48a into master Nov 8, 2021
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ci-lint-avoid-changing-optional-int-int-none branch November 8, 2021 21:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wedamija wedamija wedamija approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanpurkhiser @wedamija