fix(perf): Fix widgets using EventsRequest #29822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes limiting which provided props were passed to events request also excluded some, such as period, project, environment, that should be updated and passed in.
Zylphrex
approved these changes
Nov 5, 2021
Comment on lines
159
to
168
| {...pick(provided, [ | ||
| 'children', | ||
| 'organization', | ||
| 'yAxis', | ||
| 'period', | ||
| 'start', | ||
| 'end', | ||
| 'environment', | ||
| 'project', | ||
| ])} |
There was a problem hiding this comment.
Nit: having this list as a constant somewhere might be useful
size-limit report
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The changes limiting which provided props were passed to events request also excluded some, such as period, project, environment, that should be updated and passed in.