Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(weekly reports): Add more logs #29819

Merged
merged 4 commits into from
Nov 5, 2021

Conversation

ceorourke
Copy link
Member

@ceorourke ceorourke commented Nov 5, 2021

Missing weekly reports still elude me, so I'm adding more logs behind a feature flag to get more data.

@ceorourke ceorourke requested a review from manuzope November 5, 2021 17:37
Copy link
Contributor

@manuzope manuzope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on putting something in prepare_organization_report to the effect of "started computing reports for x org"? That way, we'll know it ran for the org and will allow us to reduce the surface area of the investigation.

@manuzope
Copy link
Contributor

manuzope commented Nov 5, 2021

I also assume you've tested this locally with settings like https://github.com/getsentry/getsentry/pull/6568?

@ceorourke
Copy link
Member Author

I also assume you've tested this locally with settings like getsentry/getsentry#6568?

@manuzope I've been trying to test this locally and haven't gotten anywhere, I'm not sure if this is just something you can't test locally or I'm not doing something right.

I deployed the getsentry PR and changed my local org slug to one in the list, ran the task manually and it fails to find my organization in the feature list. I've also ran the test_deliver_organization_user_report test and added in the test's org slug which didn't work. The only way I can get any print statements to run (I added prints just before the logs that are feature flagged) is by enabling the feature in server.py.

I read through the feature flag docs and removed the True parameter as suggested if not using Flagr but that didn't change anything for my local testing either, but I've committed that since it seems like what I'm supposed to do.

At this point (2 on Friday) I might just deploy this PR soon if I haven't heard back from anyone on how to test this locally and hope for the best on Monday, because I am out of ideas.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants