Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(sentry-metrics): Remove unneeded option #29815

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

MeredithAnya
Copy link
Member

I think this was brought up in a comment on an older PR and I forgot to address but because we already have:

@batching_kafka_options("ingest-metrics-consumer")

we shouldn't need the --group_id option

@MeredithAnya MeredithAnya requested a review from a team November 5, 2021 17:23
@MeredithAnya MeredithAnya merged commit 01ec97f into master Nov 8, 2021
@MeredithAnya MeredithAnya deleted the sentry-metrics/cleanup-11-5-21 branch November 8, 2021 17:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants