fix(appstore-connect): Return more detailed errors when API credentials are unusable during setup #29808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@priscilawebdev heads up that this doesn't make any changes to the FE, but a previously partially unused case in the FE will now be used once these changes are in. |
flub
approved these changes
Nov 5, 2021
| try: | ||
| apps = appstore_connect.get_apps(session, credentials) | ||
| except appstore_connect.UnauthorizedError: | ||
| raise AppConnectAuthenticationError() |
There was a problem hiding this comment.
python oddity, you don't actually have to instantiate the class you want to "raise". If you pass a type to raise it will instantiate it for you. But there's no harm in doing this either so doesn't really matter.
There was a problem hiding this comment.
this is probably the second or third time i've done this in a PR, thanks for pointing this out 🙃
priscilawebdev
approved these changes
Nov 7, 2021
142c12d to
1e7fa19
Compare
0f90a60 to
d154ad1
Compare
d154ad1 to
e2a683a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up credentials the only feedback that's returned when they're wrong (invalid, not enough perms) is this:
This changes things so that the user will see the following two errors instead based on what App Store Connect tells us:
Front end work was already completed as a part of #29728 since there's some shared FE code between these two PRs.
I don't believe there should be any issues deploying this change as the FE already is capable of handling what this endpoint returns prior to and after this change.