Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notification): Correct overriding in where_should_be_participating #29802

Merged
merged 2 commits into from
Nov 4, 2021
Merged

fix(notification): Correct overriding in where_should_be_participating #29802

merged 2 commits into from
Nov 4, 2021

Conversation

mgaeta
Copy link
Contributor

@mgaeta mgaeta commented Nov 4, 2021

In #29757 we were on the right track but were implementing the update() incorrectly.
In this fix we apply the different levels of NotificationSettings in order.

@mgaeta mgaeta requested a review from a team November 4, 2021 22:32
ceorourke
ceorourke approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@ceorourke ceorourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaay it works locally for me, but might be worth adding some more mutations of settings in tests.

@mgaeta mgaeta merged commit 73294e4 into master Nov 4, 2021
@mgaeta mgaeta deleted the fix/notification-settings-defaults-2 branch November 4, 2021 23:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ceorourke ceorourke ceorourke approved these changes

Assignees

@ceorourke ceorourke

Labels
Component: Notifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgaeta @ceorourke