fix(grouping): Tag first grouping variant's name on transaction [INGEST-494] #29792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* I want to get a general feeling for how many events in save_event are grouped by message vs stacktrace. Adding this tag to the save_event transaction. * When `short_id.timeout` message is emitted in event manager, it's often because of bad grouping. It's useful to know which variant created so many different hashes. Then we can use this data to improve either message grouping or stacktrace grouping.
beezz
approved these changes
Nov 4, 2021
jjbayer
reviewed
Nov 5, 2021
| ) | ||
|
|
||
| flat_hashes = [hash_ for _, hash_ in flat_hashes] | ||
| hierarchical_hashes = [hash_ for _, hash_ in hierarchical_hashes] |
There was a problem hiding this comment.
Why not expose the names in the interface of get_hashes, and then call set_tag in the event_manager? Just so this tag is not set accidentally when get_hashes() is called from other places.
There was a problem hiding this comment.
I think we can live with this tag being accidentally set. Since the majority of get_hashes callers are untyped I didn't dare refactor this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to get a general feeling for how many events in save_event are
grouped by message vs stacktrace. Adding this tag to the save_event
transaction.
When
short_id.timeoutmessage is emitted in event manager, it'soften because of bad grouping. It's useful to know which variant created
so many different hashes. Then we can use this data to improve either
message grouping or stacktrace grouping.