Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(discover): disable bar chart animation on discover #29783

Merged
merged 2 commits into from
Nov 8, 2021

Conversation

edwardgou-sentry
Copy link
Contributor

Bar chart animation activating on every rerender in Discover causes some visual jank. Disabling animation for barcharts in discover to fix this issue.

@edwardgou-sentry edwardgou-sentry requested a review from a team November 4, 2021 14:49
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner November 4, 2021 14:49
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2021

size-limit report

Path Base Size (122fbd2) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.77 KB 52.76 KB -0.01% 🔽
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.89 KB 70.89 KB 0%

@edwardgou-sentry edwardgou-sentry merged commit 08f008f into master Nov 8, 2021
@edwardgou-sentry edwardgou-sentry deleted the fix/disable-bar-chart-animation branch November 8, 2021 17:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants