Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(ui): useTeams and Teams util for alert/incident list #29773

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

davidenwang
Copy link
Contributor

Multiple instances of withTeams in this page such as on the <TeamFilter> which can be replaced with useTeams and have searching functionality.

Also on the alert list table for determining if an alert can be edited or not.

Replaced all instances with either useTeams or <Teams> so that there is a full list of user teams if the user's org has more than 100 teams, and functionality to search for more.

image

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2021

size-limit report

Path Base Size (30d87a6) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.76 KB 52.76 KB +0.01% 🔺
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.89 KB 70.89 KB 0%

@davidenwang davidenwang marked this pull request as ready for review November 4, 2021 22:02
@davidenwang davidenwang requested a review from a team November 4, 2021 22:02
Copy link
Member

@scttcper scttcper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great

@davidenwang davidenwang merged commit 9ed041b into master Nov 5, 2021
@davidenwang davidenwang deleted the davidenwang/use-teams-alert-list branch November 5, 2021 19:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants