Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Remove inf percentage from change alert graphs #29752

Merged

Conversation

taylangocmen
Copy link
Contributor

@taylangocmen taylangocmen commented Nov 3, 2021

This removes the inf% from change alert graphs, we instead show nothing, because the alert ignores if comparison stats for an interval is 0.

Old tooltip:
Screen Shot 2021-11-03 at 1 42 49 PM

New tooltip:
Screen Shot 2021-11-03 at 1 42 00 PM

@taylangocmen taylangocmen requested a review from a team November 3, 2021 20:41
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2021

size-limit report

Path Base Size (0128740) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.72 KB 52.72 KB -0.01% 🔽
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.89 KB 70.89 KB 0%

@taylangocmen taylangocmen requested a review from scttcper November 3, 2021 20:43
@taylangocmen taylangocmen merged commit 4b3c05f into master Nov 3, 2021
@taylangocmen taylangocmen deleted the taylangocmen/fix-alert-details-tooltip-change-pct-2 branch November 3, 2021 21:09
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants