fix(suspect-spans): Span ops endpoint should not be paged yet #29749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The span ops endpoint is being accidentally paged along with the spans tab. This should not be paginating at all.
k-fish
approved these changes
Nov 4, 2021
| @@ -75,6 +75,8 @@ export default function OpsFilter(props: Props) { | |||
| location={location} | |||
| orgSlug={organization.slug} | |||
| eventView={opsFilterEventView} | |||
| cursor="0:0:1" | |||
There was a problem hiding this comment.
Another one? Hmmmmm there should be a cleaner approach than this. I think maybe we should have a way for queries to change which url param they (or the EventView payload function that gets called) looks at for the cursor, and use null to indicate that the EventView should not use the location cursor?
There was a problem hiding this comment.
Yeah, there should definitely be a clean way to handle this. Going to merge this for now and revisit later.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The span ops endpoint is being accidentally paged along with the spans tab. This
should not be paginating at all.