fix(gitlab): Refresh access token process #29747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaeta
reviewed
Nov 3, 2021
mgaeta
approved these changes
Nov 3, 2021
This was referenced Nov 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
When creating a Gitlab integration, the defaults have changed. Previously, there was no checkbox for "Expire access tokens". Presumably, the tokens did not expire. But now this is the default and we should really support refresh tokens.
We are using the Authorization flow described here: https://docs.gitlab.com/ee/api/oauth2.html#authorization-code-flow
There will be a followup PR to update the instructions.