Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perf): Add empty state for list widget #29738

Merged
merged 4 commits into from
Nov 3, 2021

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented Nov 3, 2021

Summary

This adds some empty state with 'no results' instead of the placeholder. Also adds a test to ensure it appears.

Screenshot

Screen Shot 2021-11-03 at 10 34 22 AM

This adds some empty state with 'no results' instead of the placeholder. Also adds a test to ensure it appears.
@k-fish k-fish requested a review from a team as a code owner November 3, 2021 14:35
Copy link
Member

@Zylphrex Zylphrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the empty widgetNoResults.tsx file an accident? Can we remove it?

@k-fish k-fish merged commit 915766c into master Nov 3, 2021
@k-fish k-fish deleted the fix/perf-landing-v3-empty-state-list-widgets branch November 3, 2021 17:46
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants