fix(ui): Adjust metric alert chart rule change gray area boundaries #29727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanpurkhiser
approved these changes
Nov 3, 2021
|
@taylangocmen looks like this fixed it only for events charts, can you please check why sessions charts are still off? |
149626f to
b7608f0
Compare
size-limit report
|
b7608f0 to
72b4907
Compare
matejminar
approved these changes
Nov 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the gray area and alert change marker in the alert details from a graphic rectangle and line to MarkArea and MarkLine. Using these is better than graphics because the boundaries are much more accurate. Even though we lose the overflowing effect of using graphics, the confusion due to inaccuracy of them was greater.
Old metric alert (non-session):
Old session alert:
New metric alert:
New session alert:
Jira: WOR-1452