fix(reprocessing): Add a lot of metrics and explicitly opt tasks into sentry performance product [INGEST-574] #29716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sentry performance product We have some metrics reported inconsistently reported via statsd and sentry, I am not sure why they only show up sometimes but let me add some more with explicit sample rate.
jjbayer
reviewed
Nov 3, 2021
| @@ -514,6 +514,8 @@ def start_group_reprocessing( | |||
| referrer="reprocessing2.start_group_reprocessing", | |||
| )["data"][0]["times_seen"] | |||
|
|
|||
| sentry_sdk.set_extra("event_count", event_count) | |||
There was a problem hiding this comment.
Is this set_extra limited to the scope of the @instrumented_task? Same question for set_tag below.
jjbayer
approved these changes
Nov 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some metrics reported inconsistently reported via statsd and
sentry, I am not sure why they only show up sometimes but let me add
some more with explicit sample rate.