fix(ui): Cropped letter descenders in TextOverflow #29696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the low line-height (1.1), the letter g's descender (the hook at the bottom) is cropped off. Setting line-height to 1.2 fixes this.
markstory
approved these changes
Nov 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the low
line-height(1.1), the letter g's descender (the hook at the bottom) is cropped off. Settingline-heightto1.2fixes this. I'm not sure why we used1.1in the first place (?). A value of1.2doesn't seem to noticeably affect the vertical alignment.Before:
After:
