Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(sentry-metrics): Run ingest-metrics-consumer in devserver #29694

Merged
merged 2 commits into from
Nov 4, 2021
Merged

ref(sentry-metrics): Run ingest-metrics-consumer in devserver #29694

merged 2 commits into from
Nov 4, 2021

Conversation

MeredithAnya
Copy link
Member

Adds option SENTRY_USE_METRICS_DEV to allow the ingest metrics consumer to start when running the devserver with workers.

Also changed the command from metrics-consumer to ingest-metrics-consumer to be more specific about which topic it's consuming from.

@MeredithAnya MeredithAnya requested review from a team, jan-auer and jjbayer November 1, 2021 17:39
jjbayer
jjbayer approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good!

@MeredithAnya MeredithAnya merged commit 7591cc3 into master Nov 4, 2021
@MeredithAnya MeredithAnya deleted the sentry-metrics/update-metrics-consumer-command branch November 4, 2021 21:45
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jjbayer jjbayer jjbayer approved these changes

@jan-auer jan-auer Awaiting requested review from jan-auer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MeredithAnya @jjbayer