Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmp_alerts): Update change alert tooltips to reflect the change alert better #29681

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

taylangocmen
Copy link
Contributor

@taylangocmen taylangocmen commented Oct 30, 2021

This updates the change alerts tooltip both in the alert rule builder and alert rule details pages. Added the change percentage to the tooltip and organized the series layouts to be more consistent.


Old tooltips:

Screen Shot 2021-11-02 at 12 58 52 PM

Screen Shot 2021-11-02 at 12 58 58 PM


New tooltips:
Screen Shot 2021-11-02 at 12 54 49 PM

Screen Shot 2021-11-02 at 12 55 01 PM

Screen Shot 2021-11-02 at 12 55 06 PM

@taylangocmen taylangocmen changed the title fix(ui): Update change alert tooltips to reflect the change alert better feat(cmp_alerts): Update change alert tooltips to reflect the change alert better Nov 2, 2021
@taylangocmen taylangocmen marked this pull request as ready for review November 2, 2021 20:00
@taylangocmen taylangocmen requested a review from a team as a code owner November 2, 2021 20:00
@taylangocmen taylangocmen requested a review from a team November 2, 2021 20:00
@taylangocmen taylangocmen merged commit 0ad534f into master Nov 3, 2021
@taylangocmen taylangocmen deleted the taylangocmen/change-alerts-graph-tooltip branch November 3, 2021 00:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants