feat(notifications): adds approval notifications to the UI

[scefali]

This PR adds the UI for approval notifications which is hidden behind the feature flag organization:slack-requsts. These approval notifications require someone with the right permissions to approve or reject requests. These notifications are at an organization level as well.

[github-actions]

size-limit report

Path	Base Size (30ba759)	Current Size	Change
src/sentry/static/sentry/dist/entrypoints/app.js	52.73 KB	52.72 KB	-0.01% 🔽
src/sentry/static/sentry/dist/entrypoints/sentry.css	70.89 KB	70.89 KB	0%

[NisanthanNanthakumar]

wouldn't this just be on or off?

[scefali]

@NisanthanNanthakumar Correct, it would be on or off. The issue is that we only use the title and description from this (

sentry/static/app/views/settings/account/notifications/notificationSettingsByType.tsx

Line 229 in 3433d51

const {title, description} = ACCOUNT_NOTIFICATION_FIELDS[notificationType];

).

It looks like we used to read all fields a change was made to basically bypass logic depending in the field:

sentry/static/app/views/settings/account/accountNotificationFineTuning.tsx

Lines 171 to 178 in 3433d51

	if (['alerts', 'deploy', 'workflow', 'approval'].includes(fineTuneType)) {
	return <NotificationSettingsByType notificationType={fineTuneType} />;
	}
	const {notifications, projects, fineTuneData, projectsPageLinks} = this.state;
	const isProject = isGroupedByProject(fineTuneType);
	const field = ACCOUNT_NOTIFICATION_FIELDS[fineTuneType];

Looks like a lot of the unused fields weren't cleaned up. We are looking at the options for some of these fields but not all of them. IMO this needs to be fixed because it was very confusing when the fields are treated differently from this file but you won't know until you look at other parts of the code.

[scefali]

Gonna put in another TODO for cleanup

[mgaeta]

This will actually require a migration because it changes a DB constraint.

[scefali]

@mgaeta good point...let me generate that, thanks!

[scefali]

@mgaeta I am seeing:

sentry django makemigrations sentry -n approval_notification_type
....
No changes detected in app 'sentry'

Maybe we don't need migrations for this kind of change anymore?

[mgaeta]

I hope so that would save a lot of time.