ref(react-testing-library): Introduce user-event #29638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejminar
reviewed
Oct 29, 2021
.vscode/settings.json
Outdated
| @@ -7,7 +7,7 @@ | |||
| "**/*.pyc": true, | |||
| "build": true, | |||
| "htmlcov": true, | |||
| "node_modules": true, | |||
| "node_modules": false, | |||
There was a problem hiding this comment.
I'm still working on it and will update this file as soon as I am done 😉
priscilawebdev
commented
Oct 29, 2021
|
|
||
| expect(container).toSnapshot(); | ||
| }); | ||
| }); | ||
|
|
||
| it('can toggle collapsed state', async function () { |
There was a problem hiding this comment.
for some reason, the order the test was running in was causing an error. I'm going to check this out and create a follow-up PR
0ee1738 to
61c3635
Compare
Base automatically changed from
fix/project-filters-and-sampling-replace-queries-with-recommended-screen
to
master
November 12, 2021 11:19
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@testing-library/user-eventfireEvent.*withuserEvent.*as it is recommended by the library author.More details:
https://kentcdodds.com/blog/common-mistakes-with-react-testing-library#not-using-testing-libraryuser-event