Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(stack-trace-interfaces): Add Native Stack Trace V2 - Part 3 - [INGEST-557] #29631

Merged
merged 48 commits into from
Oct 29, 2021
Merged

ref(stack-trace-interfaces): Add Native Stack Trace V2 - Part 3 - [INGEST-557] #29631

merged 48 commits into from
Oct 29, 2021

Conversation

priscilawebdev
Copy link
Member

@priscilawebdev priscilawebdev commented Oct 28, 2021 •
edited
Loading

Everything is feature flagged [organizations:native-stack-trace-v2]

We are currently implementing the new native stack trace design and this PR is only one of many that are to come.

This "Part -3" implementation brings:

  • StackTraceV2 - a new component, which uses the TraceEventDataSection
  • Makes TraceEventDataSection Responsive
  • Fixes dropdown issues on smaller devices

Before:

small
image

medium
image

larger
image

After:

small
image

medium
image

larger
image

  • Disable actions if they are not available - this is new
    image
    image

@priscilawebdev
ref(crashContent): Move crash content related files to folder
da948ed
@priscilawebdev
removed unused file
9d59c47
@priscilawebdev
tests
29b19b5
@priscilawebdev
tests2
5b71d34
@priscilawebdev
ref(threads-interface): Add threads interface V2
68d1ba1
@priscilawebdev
wip
0509a0f
@priscilawebdev
added traceEventDataSection
3db480f
@priscilawebdev
revert test
b0c2cea
@priscilawebdev
removed repeat css
fcfb91a
@priscilawebdev
remove comment
aa9e41f
@priscilawebdev
remove test test file
c9c75a0
@priscilawebdev
update thread selector
03e1ede
@priscilawebdev
fixed event section title for non thread
5087bb2
@priscilawebdev
ref(crashContent): Move crash content related files to folder
57d2983
@priscilawebdev
ref(native-stack-trace): Add new design - part 2
1466d81
@priscilawebdev
fixed tests
f90f098
@priscilawebdev
fix css lint error
1d60855
@priscilawebdev
fixed visual snapshot render error
bd300c1
@priscilawebdev
ref(interface-files): Move files to appropriate folder
58d35e8
@priscilawebdev
ref(crashContent): Move crash content related files to folder
74b8cbc
@priscilawebdev
removed unused file
6b8361f
@priscilawebdev
tests
a9dc5f6
@priscilawebdev
tests2
1710655
@priscilawebdev
ref(threads-interface): Add threads interface V2
2b9e6f3
@priscilawebdev
wip
e65a69d
@priscilawebdev
added traceEventDataSection
cc3e798
@priscilawebdev
revert test
e5f2033
@priscilawebdev
removed repeat css
876b0f9
@priscilawebdev
remove comment
0bad552
@priscilawebdev
remove test test file
5a06f24
@priscilawebdev priscilawebdev changed the base branch from master to ref/add-threads-interface-new-version-part-2 October 28, 2021 11:00
@priscilawebdev priscilawebdev marked this pull request as ready for review October 28, 2021 11:29
@priscilawebdev priscilawebdev requested a review from a team as a code owner October 28, 2021 11:29
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2021 •
edited
Loading

size-limit report

Path Base Size (8b23b3f) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.73 KB 52.73 KB -0.01% 🔽
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.89 KB 70.89 KB 0%

@priscilawebdev priscilawebdev requested a review from a team October 28, 2021 11:46
Base automatically changed from ref/add-threads-interface-new-version-part-2 to master October 29, 2021 08:52
@priscilawebdev priscilawebdev enabled auto-merge (squash) October 29, 2021 09:16
@priscilawebdev priscilawebdev merged commit 9baf405 into master Oct 29, 2021
@priscilawebdev priscilawebdev deleted the ref/native-stack-trace-new-design-part-3 branch October 29, 2021 09:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matejminar matejminar matejminar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@priscilawebdev @matejminar