Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suspect-spans): Show arrow next to sorting key #29615

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

Zylphrex
Copy link
Member

The sort order on the spans tab is not obvious. This adds an arrow next to the
value that is sorted upon to make it clearer.

@Zylphrex Zylphrex requested a review from a team as a code owner October 27, 2021 21:09
Base automatically changed from fix/occurrences-should-exist-in-header-when-sorting to master October 29, 2021 18:13
The sort order on the spans tab is not obvious. This adds an arrow next to the
value that is sorted upon to make it clearer.
@github-actions
Copy link
Contributor

size-limit report

Path Base Size (476439e) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.72 KB 52.73 KB +0.01% 🔺
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.89 KB 70.89 KB 0%

@Zylphrex Zylphrex merged commit 7b14c5c into master Oct 29, 2021
@Zylphrex Zylphrex deleted the feat/show-arrow-next-to-sorting-key-header branch October 29, 2021 18:54
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants