Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suspect-spans): Add occurrences to header when sorting #29611

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

Zylphrex
Copy link
Member

When sorting by occurrences in the spans tab, the occurrences should be visible
as one of the header items. It will take the place of the frequency header.

When sorting by occurrences in the spans tab, the occurrences should be visible
as one of the header items. It will take the place of the frequency header.
@Zylphrex Zylphrex requested a review from a team as a code owner October 27, 2021 19:47
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2021

size-limit report

Path Base Size (e1dde94) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.75 KB 52.75 KB -0.01% 🔽
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.89 KB 70.89 KB 0%

The percentage alone doesn't provide enough information. This adds the raw
counts in the tooltip.
@Zylphrex Zylphrex merged commit 476439e into master Oct 29, 2021
@Zylphrex Zylphrex deleted the fix/occurrences-should-exist-in-header-when-sorting branch October 29, 2021 18:13
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants