Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmp_alerts): Show comparison data in dashed line in alert event stat chart #29603

Merged
merged 6 commits into from
Oct 28, 2021
Merged

feat(cmp_alerts): Show comparison data in dashed line in alert event stat chart #29603

merged 6 commits into from
Oct 28, 2021

Conversation

taylangocmen
Copy link
Contributor

This updates the event stats chart in the alert rule creation to show the comparison stats in a dashed line. Also added a marker formatter function to conditionally format the marker in the chart tooltip. Fixed the comparisonDelta in the events stats request, should be seconds in the request but it's in minutes on the alertRule, similarly to interval

Old chart:

Screen Shot 2021-10-27 at 10 27 17 AM

New chart:

Screen Shot 2021-10-27 at 10 25 56 AM

@taylangocmen taylangocmen requested a review from a team as a code owner October 27, 2021 17:29
@taylangocmen taylangocmen requested a review from a team October 27, 2021 17:29
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2021 •
edited
Loading

size-limit report

Path Base Size (01c7a73) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.75 KB 52.75 KB +0.01% 🔺
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.89 KB 70.89 KB 0%

@taylangocmen taylangocmen force-pushed the taylangocmen/change-alerts-graph-data branch from 6bd2e62 to a4d2e09 Compare October 27, 2021 22:46
@taylangocmen taylangocmen requested a review from scttcper October 28, 2021 02:02
@taylangocmen taylangocmen merged commit eb0c047 into master Oct 28, 2021
@taylangocmen taylangocmen deleted the taylangocmen/change-alerts-graph-data branch October 28, 2021 16:49
@taylangocmen taylangocmen mentioned this pull request Oct 28, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scttcper scttcper Awaiting requested review from scttcper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taylangocmen @scttcper