Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboard): Remove new badge on Dashboard sidebar #29600

Merged
merged 3 commits into from
Oct 28, 2021

Conversation

shruthilayaj
Copy link
Member

Remove the new badge on Dashboards in the sidebar
since it's not really a new feature anymore. Not sure
when it was added but basically it got hidden because
of how we evaluate showing it:
const showIsNew = isNew && !localStorage.getItem(isNewSeenKey);

Before
Screen Shot 2021-10-27 at 12 38 36 PM

After
Screen Shot 2021-10-27 at 12 38 44 PM

Remove the new badge on Dashboards in the sidebar
since it's not really a new feature anymore. Not sure
when it was added but basically it got hidden because
of how we evaluate showing it:
`const showIsNew = isNew && !localStorage.getItem(isNewSeenKey);`
@shruthilayaj shruthilayaj marked this pull request as ready for review October 27, 2021 16:44
@shruthilayaj shruthilayaj requested a review from a team as a code owner October 27, 2021 16:44
@shruthilayaj shruthilayaj requested a review from a team October 27, 2021 16:44
@shruthilayaj shruthilayaj merged commit 5219087 into master Oct 28, 2021
@shruthilayaj shruthilayaj deleted the chore/remove-new-badge-on-dashboard branch October 28, 2021 13:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants