fix(repositories-settings): Disable UI components in case of no permission - [ISSUE-1329] #29598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priscilawebdev
commented
Oct 27, 2021
| <Access access={['project:write']}> | ||
| {({hasAccess}) => ( | ||
| <Fragment> | ||
| <ButtonTooltip |
There was a problem hiding this comment.
The button component has the title prop that could have been used, but due to an issue, wrapping the Button component with the Tooltip component was a better solution.
flub
approved these changes
Oct 27, 2021
markstory
approved these changes
Oct 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has no "project edit" permission, a couple of buttons in the UI have to be disabled and provide a message to the user saying that he has no permission.
Preview:
ps:
backend team will update the validation endpoint
/projects/${orgSlug}/${project.slug}/appstoreconnect/validate/${appStoreConnectSymbolSourceId}/so we the UI will be able to expose all non-sensitive app store connect data to all users independently of the user role. When this happens the "placeholder" component won't load foreverSince the refresh credentials (App store connect) code will be soon removed, I did not touch it in this PR
In this part of the UI I am facing the same issue that this PR tries to solve fix(ui): Un-disable buttons for hover event propagation #29413