ref(plugins): Remove Clubhouse, Teamwork, and VSTS plugins #29584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceorourke
commented
Oct 26, 2021
| @@ -9,9 +9,6 @@ | |||
|
|
|||
| # Dict with the plugin_name as the key, and enabling_feature_name as the value | |||
| SHADOW_DEPRECATED_PLUGINS = { | |||
There was a problem hiding this comment.
I'm leaving this for future deprecations
ec0eb47 to
a4ae248
Compare
mgaeta
approved these changes
Oct 26, 2021
| @@ -39,7 +35,7 @@ def get(self, request, organization): | |||
| integrations = Integration.objects.filter( | |||
| organizationintegration__organization=organization, | |||
| organizationintegration__status=ObjectStatus.ACTIVE, | |||
| provider__in=("bitbucket", "github", "vsts"), | |||
| provider__in=("bitbucket", "github"), | |||
There was a problem hiding this comment.
Can you pull this list to a constant at the top of the file
UNMIGRATABLE_PROVIDERS = ("bitbucket", "github")
leeandher
reviewed
Oct 26, 2021
| "clubhouse": "organizations:integrations-ignore-clubhouse-deprecation", | ||
| "vsts": "organizations:integrations-ignore-vsts-deprecation", | ||
| } | ||
| SHADOW_DEPRECATED_PLUGINS = {} |
There was a problem hiding this comment.
Do you mind adding an example as a comment for future plugin deprecation?
SHADOW_DEPRECATED_PLUGINS = {
# "exampleslug": "organizations:integrations-ignore-exampleslug-deprecation"
}e8ed908 to
e331d6c
Compare
aeab62f to
4e84c73
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all code related to the Clubhouse, Teamwork, and VSTS plugins as they are deprecated and we have better versions of them.
Related getsentry PR must be merged first: https://github.com/getsentry/getsentry/pull/6509