Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(suspect-span): Show frequency as percentage #29577

Merged
merged 1 commit into from
Oct 27, 2021
Merged

feat(suspect-span): Show frequency as percentage #29577

merged 1 commit into from
Oct 27, 2021

Conversation

Zylphrex
Copy link
Member

This changes the frequency from a count to a relative percentage to give a sense
of the proportion of transactions that contains a specific span.

@Zylphrex
feat(suspect-span): Show frequency as percentage
15dc909 
This changes the frequency from a count to a relative percentage to give a sense
of the proportion of transactions that contains a specific span.
@Zylphrex Zylphrex requested a review from a team as a code owner October 26, 2021 16:59
k-fish
k-fish approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@k-fish k-fish left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be asserting the number of times the api gets called in the tests, I think. It's pretty easy for a dependent key to start causing extra api calls to fire.

@Zylphrex Zylphrex merged commit 2640681 into master Oct 27, 2021
@Zylphrex Zylphrex deleted the feat/show-suspect-span-frequency-as-percentage branch October 27, 2021 19:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@k-fish k-fish k-fish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zylphrex @k-fish