ref(tests): Replace waitFor with waitForElementToBeRemoved in RTL #29547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejminar
commented
Oct 25, 2021
Comment on lines
-17
to
-20
| await waitFor(() => { | ||
| expect(screen.queryByTestId('loading-indicator')).not.toBeInTheDocument(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Looks like some of these are not needed. If it makes our tests unstable, I'll put them back.
billyvg
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
@matejminar Should we be summarizing the work you've been doing in https://develop.sentry.dev/frontend/#testing?
|
@billyvg Yeah, I'll draft something next week. Will sync with @evanpurkhiser, he also mentioned creating a document for common RTL pitfalls and use cases. |
priscilawebdev
approved these changes
Oct 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The waitForElementToBeRemoved async helper function uses a callback to query for the element on each DOM mutation and resolves to true when the element is removed.
Using MutationObserver is more efficient than polling the DOM at regular intervals with waitFor.