ref(package.json): Add ua-parser-js resolution #29536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
markstory
approved these changes
Oct 25, 2021
|
Good call 👍 |
| @@ -188,6 +188,7 @@ | |||
| "fsevents": "^2.3.2" | |||
| }, | |||
| "resolutions": { | |||
| "**/ua-parser-js": "<=0.7.28", | |||
There was a problem hiding this comment.
This is one of those scenarios where it would be really nice if we could have a comment in here as to why it's locked.
There was a problem hiding this comment.
yes but unfortunately comments are not permitted in json :/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the library
ua-parser-jshas been hijacked (faisalman/ua-parser-js#536) and we indirectly use it throughreact-router@3.2.0(ua-parser-js@^0.7.18). This resolution is being added as a precaution