Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(stack-trace-interfaces): Add Native Stack Trace V2 - Part 2 - [INGEST-512] #29532

Merged
merged 42 commits into from
Oct 29, 2021

Conversation

priscilawebdev
Copy link
Member

@priscilawebdev priscilawebdev commented Oct 25, 2021

Everything is feature flagged [organizations:native-stack-trace-v2]

We are currently implementing the new native stack trace design and this PR is only one of many that are to come.

This "Part -2" implementation brings:

  • All TraceEventDataSection's display options working
  • ExceptionV2 - a new component, which uses the TraceEventDataSection
  • NativeV2 component with the new updates
  • StacktraceContentV3 component (Platform icon was removed and StyledList component contains new styles)
  • Renamed stacktrace* files to stack**T**race*
  • Stack Trace tests now needs to have <OrganizationContext.Provider value={organization}>

Preview:

new-native-2

@priscilawebdev priscilawebdev changed the base branch from master to ref/add-threads-interface-new-version October 25, 2021 09:12
@priscilawebdev priscilawebdev changed the title Ref/add threads interface new version part 2 ref(stack-trace-interfaces): Add Native Stack Trace V2 - Part 2 - [INGEST-508] Oct 25, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2021

size-limit report

Path Base Size (395eed6) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.73 KB 52.73 KB +0.02% 🔺
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.89 KB 70.89 KB 0%

@priscilawebdev priscilawebdev force-pushed the ref/add-threads-interface-new-version branch from fd87002 to 5087bb2 Compare October 25, 2021 11:13
@priscilawebdev priscilawebdev marked this pull request as ready for review October 25, 2021 13:57
@priscilawebdev priscilawebdev requested a review from a team as a code owner October 25, 2021 13:57
@@ -86,43 +89,62 @@ describe('ExceptionStacktraceContent', () => {
};

it('default behaviour', () => {
const wrapper = mountWithTheme(<ExceptionStacktraceContent {...props} />);
const wrapper = mountWithTheme(
<OrganizationContext.Provider value={organization}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add this provider here:

function makeAllTheProviders(context?: Record<string, any>) {
return function ({children}: {children?: React.ReactNode}) {
const ContextProvider = context ? createProvider(context) : Fragment;
return (
<ContextProvider>
<CacheProvider value={cache}>
<ThemeProvider theme={lightTheme}>{children}</ThemeProvider>
</CacheProvider>
</ContextProvider>
);
};
}

so that we don't have to wrap all these components manually.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that in a follow-up 😉

Base automatically changed from ref/add-threads-interface-new-version to master October 29, 2021 08:15
@priscilawebdev priscilawebdev enabled auto-merge (squash) October 29, 2021 08:33
@priscilawebdev priscilawebdev merged commit 8b23b3f into master Oct 29, 2021
@priscilawebdev priscilawebdev deleted the ref/add-threads-interface-new-version-part-2 branch October 29, 2021 08:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants