-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(stack-trace-interfaces): Add Native Stack Trace V2 - Part 2 - [INGEST-512] #29532
ref(stack-trace-interfaces): Add Native Stack Trace V2 - Part 2 - [INGEST-512] #29532
Conversation
size-limit report
|
d9c5c53
to
6781bcd
Compare
fd87002
to
5087bb2
Compare
6781bcd
to
1466d81
Compare
…eads-interface-new-version-part-2
…eads-interface-new-version-part-2
…eads-interface-new-version-part-2
@@ -86,43 +89,62 @@ describe('ExceptionStacktraceContent', () => { | |||
}; | |||
|
|||
it('default behaviour', () => { | |||
const wrapper = mountWithTheme(<ExceptionStacktraceContent {...props} />); | |||
const wrapper = mountWithTheme( | |||
<OrganizationContext.Provider value={organization}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add this provider here:
sentry/tests/js/sentry-test/reactTestingLibrary.tsx
Lines 24 to 35 in b860a90
function makeAllTheProviders(context?: Record<string, any>) { | |
return function ({children}: {children?: React.ReactNode}) { | |
const ContextProvider = context ? createProvider(context) : Fragment; | |
return ( | |
<ContextProvider> | |
<CacheProvider value={cache}> | |
<ThemeProvider theme={lightTheme}>{children}</ThemeProvider> | |
</CacheProvider> | |
</ContextProvider> | |
); | |
}; | |
} |
so that we don't have to wrap all these components manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do that in a follow-up 😉
Everything is feature flagged [
organizations:native-stack-trace-v2
]We are currently implementing the new native stack trace design and this PR is only one of many that are to come.
This "Part -2" implementation brings:
stacktrace*
files tostack**T**race*
<OrganizationContext.Provider value={organization}>
Preview: