feat(discover): Add to Dashboard default Widget Display Type based on Discover Query #29518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shruthilayaj
approved these changes
Oct 22, 2021
| if (!widget) { | ||
| this.state = { | ||
| title: defaultTitle ?? '', | ||
| displayType: DisplayType.LINE, | ||
| displayType: defaultDisplayType ?? DisplayType.LINE, |
There was a problem hiding this comment.
nittiest nit: can we name this prop displayType instead of defaultDisplayType? because technically DisplayType.LINE is the default 😛
There was a problem hiding this comment.
Yes, updated!
size-limit report
|
Ahh good call on the Top Events, forgot about that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Discover
Add to Dashboardmodal to default the Display Type based on the Display Mode of the saved query. ie if the Discover query is in World Map view, clickingAdd to Dashboardwill default the widget to World Map type.